Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tensorflow #67

Open
rettinghaus opened this issue Apr 2, 2024 · 2 comments
Open

Update Tensorflow #67

rettinghaus opened this issue Apr 2, 2024 · 2 comments

Comments

@rettinghaus
Copy link

Minimum Tensorflow version sticks with 2.4 but should be 2.12.1 to be in line with eynollah.

@cneud
Copy link
Member

cneud commented Apr 10, 2024

Due to being stuck on CentOS 7 with rather outdated nvidia drivers, we can only currently test up to Tensorflow <=2.11.x and CuDNN <=8.1.x here (applies for sbb_binarization, eynollah and sbb_pixelwise_segmentation). I will make the updates to READMEs and requirements.txt asap.

@bertsky
Copy link
Contributor

bertsky commented Oct 11, 2024

@cneud your requirement change in eynollah pinned that to 2.12. That in turn excludes using it together (in the same venv, as is most useful for ocrd_all) with sbb-binarization, which with your change requires <2.12.

This difference involves a significant switch from protobuf 3 to 4.

I have tried with the CI tests (running the OCR-D wrapper on kant_aufklaerung_1784-page-region): TF 2.11 and 2.12 produce binary-identical results.

So can we please update to 2.12 here?

(Also, why pin eynollah to 2.12.1 rather than 2.12.*?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants