-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsetting custom nvim binary does not work #1022
Comments
Thanks for the report. That should be throwing up an alert saying incompatible version (upstream fixes were needed for this to work which are in newer versions) can you let me know if that alert shows. We will look at why unsettling doesn’t work. |
Exactly, that's my experience, too. No alert and just the blank window after a few seconds at startup. |
I'm afraid, I cannot reproduce the issue. I'm not sure, but, I made a small change which might fix the issue. Can you please try https://github.com/qvacua/vimr/releases/tag/snapshot%2F20231129.173509 ? |
BTW: @p3palazzo : Which version of macOS are you using? |
Ventura with the latest updates applied. |
@p3palazzo : My guess is that I cannot reproduce it due to a subtle difference between macOS versions; I'm on Sonoma. If my guess is right, the new snapshot above should fix the issue: Please try it. |
Now it clears the path to the incompatible nvim binary on quit and relaunch, which solves the blank window problem, but still doesn't throw any alert. |
I’ll take a look at the alert side. |
I have some fixes for getting an incompatible version alert to show (it's a bit complex as older neovim without the upstream fix we submitted will block io until a connection is made on stdin, but we should have something soon. |
Expected behavior: Deleting the contents of the
Settings > Advanced > Neovim Binary
text field should unset the custom nvim binary.Actual behavior: The settings reverts to the last contents of the Neovim Binary field. Only manually editing the
~/Library/Preferences/com.qvacua.VimR.plist
file manages to unset this customization.Additionally, using the Homebrew nvim binary version 0.9.4 as the custom Neovim Binary does not work and results in a blank window in vimr.
Version 0.45.0 (20231122.130444)
The text was updated successfully, but these errors were encountered: