Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Violation #34

Closed
mymindstorm opened this issue Nov 6, 2022 · 4 comments
Closed

License Violation #34

mymindstorm opened this issue Nov 6, 2022 · 4 comments
Assignees

Comments

@mymindstorm
Copy link

Hi @qwreey75 ,

I appreciate that you forked my extension at mymindstorm/gnome-volume-mixer! But, I noticed that you removed my original LICENSE file. Even though you have refactored a lot of the files related to gnome-volume-mixer, you must properly attribute the source of that code by complying with the original LICENSE file.

Regards,
@mymindstorm

@qwreey
Copy link
Owner

qwreey commented Nov 6, 2022

Sorry for my silly mistake! Can you please confirm if I am solving this situation in the right way?

  1. I added original LICENSE file into master branch
    image
    image
    PS. this file should be included on distributed file? I have question that adding license file is not out of Review Guidelines "Don't include unnecessary files"?

  2. I added about page on settings, and added LICENSE information
    image

image
Also, it linked into this page

Can you tell me if more action is needed?

PS. Due to I'm not a native English speaker, I can't use English well. Sorry for my silly English skill!

@qwreey
Copy link
Owner

qwreey commented Nov 6, 2022

PS. this file should be included on distributed file? I have question that adding license file is not out of Review Guidelines "Don't include unnecessary files"?

image
I checked that other extension has LICENSE file on distribution. I will include license file on distribution!

PS: If you ok, you can close issue! or more action is needed, please tell me that!

@qwreey qwreey self-assigned this Nov 6, 2022
@qwreey
Copy link
Owner

qwreey commented Nov 6, 2022

image

@mymindstorm
Copy link
Author

This works just fine for me, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants