Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run time issue with queued argument of type uint32_t #660

Open
pasnox opened this issue Oct 16, 2024 · 5 comments
Open

Run time issue with queued argument of type uint32_t #660

pasnox opened this issue Oct 16, 2024 · 5 comments

Comments

@pasnox
Copy link
Contributor

pasnox commented Oct 16, 2024

The omemo stack use that in signals connection, unfortunately it's not registered via qRegisterMetatype and cause run time issue in xmpp, which break kaidan omemo support.
This would lead to have some contact for which I can speak omemo, and some not.
Kaidan tried to fix it, but it seems not enough and needs to be fixed in xmpp itself as it's there the queued connectons are done.

@lnjX
Copy link
Member

lnjX commented Oct 20, 2024

Where are queued connections done in QXmpp?

@melvo
Copy link
Contributor

melvo commented Oct 21, 2024

There are several signals emitted in the OMEMO manager such as

Q_EMIT q->deviceAdded(jid, deviceId);
having parameters of type uint32_t. Could that be the problem?

@lnjX
Copy link
Member

lnjX commented Oct 21, 2024

Those signals don't use queued connections, because both OmemoManager and OmemoManagerPrivate are always on the same thread.

@lnjX
Copy link
Member

lnjX commented Oct 21, 2024

And the other (easier) option to solve this issue is probably to use quint32 instead of uint32_t, I guess?

@pasnox
Copy link
Contributor Author

pasnox commented Oct 21, 2024

I did not check the code, I just saw Qt throwing the usual warning about queued arguments type not registered, so somewhere in QXmpp or kaidan there is an issue. And yes moving to quint32 is probably a better change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants