Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace glue with htmltools #20

Open
kbodwin opened this issue Aug 11, 2020 · 0 comments
Open

replace glue with htmltools #20

kbodwin opened this issue Aug 11, 2020 · 0 comments

Comments

@kbodwin
Copy link
Collaborator

kbodwin commented Aug 11, 2020

Suggested by @gadenbuie :

On that last point, it'd be worth thinking about using htmltools instead of glue to create the HTML tags. One problem that could arise with the current approach is that it's possible to escape the style string and open a new attribute or tag. I mean, I doubt anyone is really running into this, but it could create odd bugs down the line. (It's how I was doing this class business before this PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant