Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find cmake on fedora #651

Closed
sn248 opened this issue Dec 15, 2024 · 2 comments
Closed

cannot find cmake on fedora #651

sn248 opened this issue Dec 15, 2024 · 2 comments

Comments

@sn248
Copy link

sn248 commented Dec 15, 2024

Hi

I am running package build on fedora systems (gcc14, intel, mkl and valgrind) and see the error:

checking for cmake... no

See - https://github.com/sn248/sundialr/actions/runs/12339396049

The build works fine on debian systems. I am using the following code for checking installation of cmake

https://github.com/sn248/sundialr/blob/master/src/scripts/cmake_config.sh

Could this be looked at?

Thanks!
Satya

@gaborcsardi
Copy link
Collaborator

gaborcsardi commented Dec 15, 2024

If your package needs cmake, you need to add it to SystemRequirements in DESCRIPTION. Your DESCRIPTION only has GNU make:
https://github.com/sn248/sundialr/blob/22ea28ccf6257df8e1506e8f53523bcb78efc65c/DESCRIPTION#L25C1-L25C19

@sn248
Copy link
Author

sn248 commented Dec 15, 2024

I changed the line to

SystemRequirements: cmake

and that seems to have done the trick regarding compilation on rhub fedora systems. Thank you!

@sn248 sn248 closed this as completed Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants