Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a rchk composite action #380

Closed
jimhester opened this issue Sep 15, 2021 · 3 comments · Fixed by #428
Closed

Create a rchk composite action #380

jimhester opened this issue Sep 15, 2021 · 3 comments · Fixed by #428

Comments

@jimhester
Copy link
Member

We should create a check-rchk composite action, which will make it easier to run rchk on GitHub Actions.

It would be useful to use in cpp11 and other packages which have a lot of C or C++ code.

It can be an adapted from what is used in arrow's CI.

https://github.com/ursacomputing/crossbow/actions/runs/1120719523/workflow#L53-L76

cc @nealrichardson

@nealrichardson
Copy link
Contributor

Here's the section of workflow where we use rchk: https://github.com/apache/arrow/blob/master/dev/tasks/r/github.linux.rchk.yml#L53-L77

@jimhester
Copy link
Member Author

We do already have https://github.com/r-lib/actions/tree/master/run-rchk to run rchk, but I think the way you are doing it feels somehow more natural than the previous approach.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants