Skip to content

Commit f59c833

Browse files
committed
Set CC as well for pkgbuild:::has_compiler_colored_diagnostics()
Otherwise this will incorrectly return `TRUE` because it compiles a C program rather than a C++ one to check if color support is available, which adds the `-fdiagnostics-color=always` flag, but g++ 4.8 doesn't actually support that, so the compilation of the C++ code in the vignettes would fail
1 parent 7a479d8 commit f59c833

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/R-CMD-check.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
sudo apt update
7070
sudo apt-get install -y g++-4.8
7171
mkdir ~/.R/
72-
echo $'CXX1X=g++-4.8\nCXX11=g++-4.8' >> ~/.R/Makevars
72+
echo $'CXX1X=g++-4.8\nCXX11=g++-4.8\nCC=gcc-4.8' >> ~/.R/Makevars
7373
7474
- name: Install macOS system dependencies
7575
if: runner.os == 'macOS'

0 commit comments

Comments
 (0)