Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to set locale before calling package_native_routine_registration_skeleton() #171

Closed
hadley opened this issue May 13, 2021 · 1 comment · Fixed by #177
Closed

Need to set locale before calling package_native_routine_registration_skeleton() #171

hadley opened this issue May 13, 2021 · 1 comment · Fixed by #177
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented May 13, 2021

Since tools:::native_routine_registration_db_from_ff_call_db() calls order(), leading to spurious diffs like r-lib/roxygen2@e8cd313

@jimhester
Copy link
Member

I think the best way to fix this would be to temporarily use C collation with withr::with_collate() when calling tools::package_native_routine_registration_skeleton()

cpp11/R/register.R

Lines 248 to 253 in 41232a8

tools::package_native_routine_registration_skeleton(path,
con,
character_only = FALSE,
include_declarations = TRUE
)

@jimhester jimhester added the feature a feature request or enhancement label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants