All functions in question appropriately fail or warn when file is missing

[IndrajeetPatil]

Reprex

Closes #334

• file_info()

library(fs)

try(file_info("this-file-does-not-exist", fail = TRUE))
#> Error : [ENOENT] Failed to stat 'this-file-does-not-exist': no such file or directory

file_info("this-file-does-not-exist", fail = FALSE)
#> Warning: [ENOENT] Failed to stat 'this-file-does-not-exist': no such file or
#> directory
#> # A tibble: 1 × 18
#>   path         type   size permissions modification_time user  group device_id
#>   <fs::path>   <fct> <fs:> <fs::perms> <dttm>            <chr> <chr>     <dbl>
#> 1 …s-not-exist <NA>     NA ---------   NA                <NA>  <NA>         NA
#> # ℹ 10 more variables: hard_links <dbl>, special_device_id <dbl>, inode <dbl>,
#> #   block_size <dbl>, blocks <dbl>, flags <int>, generation <dbl>,
#> #   access_time <dttm>, change_time <dttm>, birth_time <dttm>

^{Created on 2024-05-12 with reprex v2.1.0}

• file_size()

library(fs)

try(file_size("this-file-does-not-exist", fail = TRUE))
#> Error : [ENOENT] Failed to stat 'this-file-does-not-exist': no such file or directory

file_size("this-file-does-not-exist", fail = FALSE)
#> Warning: [ENOENT] Failed to stat 'this-file-does-not-exist': no such file or
#> directory
#> NA

^{Created on 2024-05-12 with reprex v2.1.0}

Concerns

@gaborcsardi Although this produces the desired behaviour, I think this is a massive change.

It is probably going to lead to breakages for packages that have been relying on the incorrect behaviour thus far: although the default for {fs} functions in question has always been fail = TRUE, these functions never failed, and they are now going to start to fail. I can already tell that {devtools} is going to break with this change.

To avoid this, should all defaults actually be changed from fail = TRUE to fail = FALSE to keep this change backward-compatible?

[IndrajeetPatil]

This is the key test for the new behaviour.

[IndrajeetPatil]

Keeping this as fail = TRUE breaks {devtools}, and for the sake of doing local development in RStudio, I changed this default, but this is something that needs to be discussed further.

[IndrajeetPatil]

This is too big of a change to be making at this point, at least for a contributor.