All functions in question appropriately fail or warn when file is missing #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reprex
Closes #334
file_info()
Created on 2024-05-12 with reprex v2.1.0
file_size()
Created on 2024-05-12 with reprex v2.1.0
Concerns
@gaborcsardi Although this produces the desired behaviour, I think this is a massive change.
It is probably going to lead to breakages for packages that have been relying on the incorrect behaviour thus far: although the default for
{fs}
functions in question has always beenfail = TRUE
, these functions never failed, and they are now going to start to fail. I can already tell that{devtools}
is going to break with this change.To avoid this, should all defaults actually be changed from
fail = TRUE
tofail = FALSE
to keep this change backward-compatible?