Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magrittr dependency #42

Closed
lawremi opened this issue Jan 26, 2016 · 1 comment
Closed

magrittr dependency #42

lawremi opened this issue Jan 26, 2016 · 1 comment
Labels
breaking change ☠️ API change likely to affect existing code

Comments

@lawremi
Copy link
Contributor

lawremi commented Jan 26, 2016

Is it really necessary to depend on magrittr? The pipe syntax seems orthogonal to an API package like gmailr. Should not the user be expected to library(magrittr) when they want access to the alternative syntax? Since the pipe theoretically applies to any API, is every library going to import and export the %>% symbol? That does not seem sustainable.

@jimhester
Copy link
Member

I think you are probably right in this case, I don't feel like it adds much to gmailr in practice either, I personally tend to construct the email with one call to gmailr::mime() myself. Also there may be a bug in the generated mail body (#34)

@jimhester jimhester added the breaking change ☠️ API change likely to affect existing code label Aug 13, 2019
@jennybc jennybc closed this as completed in 8f0f4b8 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Development

No branches or pull requests

2 participants