-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common req_perform_
prefix
#335
Conversation
R/multi-req.R
Outdated
#' # you'll need to inspect the results to figure out which requests fails | ||
#' fail <- vapply(resps, inherits, "error", FUN.VALUE = logical(1)) | ||
#' resps[fail] | ||
multi_req_perform <- function(reqs, paths = NULL, pool = NULL, cancel_on_error = FALSE) { | ||
req_perform_multi <- function(reqs, paths = NULL, pool = NULL, cancel_on_error = FALSE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be req_perform_parallel()
? At least this sounds a bit more intuitive to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I like that name.
I'm not sure we want to stick with |
How about |
@mgirlich should we rename |
I like |
Co-authored-by: Maximilian Girlich <maximilian.girlich@metoda.com>
And move to own file
#Conflicts: # NEWS.md
This makes me lean towards making the next release 1.0.0 again. |
I'm swinging towards Or possibly Maybe we need |
One use case that comes to my mind for Harder to come up with something for GET requests. Basically the only things that comes to my mind is if you don't want to do too many requests (e.g. because they cost something) but you don't know whether you will need all of them. |
I'll make the change to |
Fixes #314