-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ANSI sequences in index.md
#2787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
f-readme-tweak
branch
2 times, most recently
from
September 28, 2024 20:00
1784d8c
to
75d8ec2
Compare
krlmlr
commented
Oct 3, 2024
@krlmlr I added two tests that fail on the main branch. 😸 |
krlmlr
commented
Oct 4, 2024
krlmlr
force-pushed
the
f-readme-tweak
branch
from
October 27, 2024 04:44
f2c9a15
to
a160ee0
Compare
hadley
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Want to add a news bullet?
krlmlr
force-pushed
the
f-readme-tweak
branch
from
October 29, 2024 18:28
a160ee0
to
5d6d62e
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are being stripped out immediately after converting Markdown to HTML. This works for me in duckplyr: https://github.com/tidyverse/duckplyr/actions/runs/11086444293/job/30803979684 is built using this branch, the result is in https://duckplyr.tidyverse.org/ .
Not sure how to add tests here.