-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purrr example in readme? #62
Comments
Do you want to submit a PR? |
This example came up in a discussion in tidyverse/purrr#149. I was thinking that everyone looking for progress bar in purrr would eventually find the issue with the example. At the time, I was also wondering if this example belonged more to dplyr or purrr, in examples for map or a vignette. Indeed, Readme is also an option Do You think it should belong in the readme ? |
@gaborcsardi I think this is a good example of how it can be used, but I just wanted to make sure it's not a hacky solution to put in a readme. @cderv the only objection I have is the |
It was just an easy and dummy example to show how it works. the pause is here to let the progress bar appears on screen with small steps. The examples in the readme are also using |
Yeah I have an example where I've tried to do some web scraping with purrr, which would be perfect for the progress bars. I'd be down to do a PR, and update this thread for your comments? |
A web scraping example is a great use case. I still believe that for a readme example to show how it works a very simple example is enough. A more thorough use case of application could belong to a blog post or other documentation. However, if you believe it fits, go ahead with the PR with a link to this issue. If you want my comment, i'll be happy to do so in the opened PR. |
Any example is good, it does not have to be realistic. You do the artificial example, you don't need to |
Please reopen if you want to submit an example. |
It would be really helpful to have an example like the following in the readme for purrr:
Do you think this is a bit hacky code, as you are sleeping every .5 seconds?
The text was updated successfully, but these errors were encountered: