Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowlist #45

Open
pawelru opened this issue Sep 17, 2024 · 4 comments
Open

feat: allowlist #45

pawelru opened this issue Sep 17, 2024 · 4 comments
Labels
feature a feature request or enhancement

Comments

@pawelru
Copy link

pawelru commented Sep 17, 2024

Consider a package in a private repo that has the following DESC file:

Package: foo
Title: My private package
BugReports: 
    https://github.com/xyz/foo/issues

(there are more links in URL etc.)

Then urlchecker correctly identifies that the url is not accessible however this problem had been addressed by implementing proper repo access rights and from the package perspective I would like to treat that url as an exception and pass urlchecker.
I'm looking for something like WORDLIST file for spelling package.

@gaborcsardi
Copy link
Member

urlchecker is the URL check code from base R, bundled up into a package, so I am reluctant to add new features to it, that would make the code different. But I'll think about it.

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Sep 17, 2024
@gaborcsardi
Copy link
Member

The other issue with a whitelist is that you'd get a clean check with urlchecker, but then if you submit the package to CRAN, it would fail the URL checks, because they do not have a whitelist.

@danielinteractive
Copy link

In our case the problem is actually not in the package itself, but in the README.md file (which is listed in .Rbuildignore therefore not packaged). Would it make sense to exclude files that are covered by .Rbuildignore?

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 20, 2024

Maybe, but surprisingly it is very hard to decide which files are covered is in .Rbuildignore.

You could build the package into a proper source R package with R CMD build, and run urlchecker on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants