-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowlist #45
Comments
urlchecker is the URL check code from base R, bundled up into a package, so I am reluctant to add new features to it, that would make the code different. But I'll think about it. |
The other issue with a whitelist is that you'd get a clean check with urlchecker, but then if you submit the package to CRAN, it would fail the URL checks, because they do not have a whitelist. |
In our case the problem is actually not in the package itself, but in the |
Maybe, but surprisingly it is very hard to decide which files are covered is in You could build the package into a proper source R package with |
Consider a package in a private repo that has the following DESC file:
(there are more links in
URL
etc.)Then
urlchecker
correctly identifies that the url is not accessible however this problem had been addressed by implementing proper repo access rights and from the package perspective I would like to treat that url as an exception and pass urlchecker.I'm looking for something like
WORDLIST
file forspelling
package.The text was updated successfully, but these errors were encountered: