-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_package() emits warning re: invalid ORCID id with recent r-devel #2060
Comments
cc @gaborcsardi (I haven't thought about this yet, but looped you in because of the connection to desc.) I note that usethis also puts an invalid license in as a default, which doesn't seem to cause a problem: Line 128 in 2cc9e5a
The basic mindset is that we're scaffolding and we're fine with the user seeing a note, warning, or error the first time that they do However it looks like some new behaviour in r-devel causes a warning at package creation time, which I don't want. (This wasn't clear to me from #2059, which only reported a warning at package build time.) |
This is also causing build failures for usethis. |
The check looks pretty robust: So I don't see an obvious to construct an obviously fake ORCID that would still pass the test. |
It would be a bummer to drop the ORCID from the scaffold, because I'm convinced that will lead to less usage of the field. But we might not have a choice? |
We can try to work around this in desc, but it is tricky, because we definitely want to catch the case when the user forgets to fill in the correct values. Ideally, the warning would show up in |
Or maybe we can use a real orcid for a fake person, e.g. https://orcid.org/0000-0002-1825-0097 But then we'd need a way to catch this ORCID when |
To reproduce, try running the following from a shell:
R --vanilla -s -e 'usethis::create_package("example", open = FALSE, rstudio = FALSE)'
I see:
Note that warning messages emitted about the invalid ORCID iD. I bumped into this with an
renv
test that was usingcreate_package()
; here's the associated backtrace.The warning appears to be emitted from the
desc
package, whendesc$normalize()
is called. I'm not sure whether this is better resolved inusethis
ordesc
, though.The text was updated successfully, but these errors were encountered: