Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision issues on M1 #119

Open
thomasp85 opened this issue Dec 8, 2021 · 0 comments
Open

Precision issues on M1 #119

thomasp85 opened this issue Dec 8, 2021 · 0 comments

Comments

@thomasp85
Copy link
Member

Evaluating some of the visual tests in ggplot2 (interestingly all of "themes look decent at larger base sizes", I can see that there is a precision issue as 0 sometimes gets written as 0.000000000000064. These are values that should be exactly equal to zero (and thus the precision determination in write_double() should keep default precision), but are not on M1.

My guess is that it is something deep down in the graphic engine, but we should probably find a good cutoff to compare to rather than test for exact equality with 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant