Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN notice: issues need fixing before 2024-07-31 #263

Closed
llrs opened this issue Jul 23, 2024 · 9 comments
Closed

CRAN notice: issues need fixing before 2024-07-31 #263

llrs opened this issue Jul 23, 2024 · 9 comments

Comments

@llrs
Copy link

llrs commented Jul 23, 2024

There is a deadline in withr that is fast approaching in 8 days and I don't see activity since January, in addition it is the day before CRAN team leaves for holidays so there isn't much time if the submission is not successful and close to the deadline.

The problems seem easy to fix:

  1. A warning for documentation mismatches: Check: for code/documentation mismatches
  2. An error in a test file (which can be harder to fix): cannot open file '/Volumes/Builds/packages/big-sur-arm64/Rlib/4.4/cli/R/sysdata.rdb': No such file or directory

Is there anything we could do to help?

@chainsawriot
Copy link

The second one appears to be false positive to me.

The first one is due to this update to the pdf() in R-devel.

https://github.com/r-devel/r-svn/blob/10fd4bd431f4d9ebf85dc94dacd7bc305d36d3fe/doc/NEWS.Rd#L45-L48

whilst here, the documentation inherits the parameters from pdf()

#' @inheritParams grDevices::pdf

One solution is to hardcode the documentation.

@llrs
Copy link
Author

llrs commented Jul 29, 2024

  1. Writing down the parameter would be a nice solution. But I think updating the docs, just roxygen2::document(), would be easy and enough to fix it.
  2. It has been constant in the last few days. I don't think it is a false positive.

@chainsawriot
Copy link

The output of roxygen2::document() depends on R version if @inheritParams grDevices::pdf is used. If we run roxygen2::document() on r-devel (thus adding "timestamp" and friends), the output will break r-release and r-oldrel.

The first one does look like an incorrect installation of cli (usually it can be fixed by either reinstalling or restarting). But I might be wrong.

@hadley
Copy link
Member

hadley commented Jul 29, 2024

Seems likely that the cli problem is a false positive.

Hopefully we're not at risk removal for not updating docs for a function that was only changed two weeks ago 😬.

@hadley
Copy link
Member

hadley commented Jul 29, 2024

@lionel- for R-devel, I think it would be nice to default to reproducible PDFs, i.e. setting timestamp and author to FALSE.

@lionel-
Copy link
Member

lionel- commented Jul 30, 2024

FYI y'all I got the email the day I left for vacations with a 2 week notice!

That's only the first deadline though so withr is not at risk from being removed from CRAN anytime soon.

@lionel-
Copy link
Member

lionel- commented Jul 31, 2024

On its way to CRAN.

@lionel- lionel- closed this as completed Jul 31, 2024
@llrs
Copy link
Author

llrs commented Jul 31, 2024

Thanks! I hope you enjoyed your holidays!
The new deadline (2024-08-18) I assume is because checks haven't catch up with the new version yet.

@lionel-
Copy link
Member

lionel- commented Jul 31, 2024

I think so, that new deadline was on the page before the release was sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants