-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rcpp Adoption in various stages #26
Comments
LCS implemented in Rcpp |
I noticed that Rcpp may not be optimal for large data in |
Maybe I need to check memory status by |
|
|
|
Check out tidycells_nightly@Rcpp-dep
While LCS is great, is_attachable is poor as compared to R. Maybe my recent knowledge of C++ is not adequate enough to implement the performant version. Also in my opinion heuristic of this level is better to be kept with R. As of now, there is no way to save A package directly can't have an optional dependency on {Rcpp}. [It has to be in Imports at least behaviorally] Hence the best idea is to remove the dependency. LCS is required in name_suggest which is a small and experimental portion of the package. Implement #36 |
source code of LCS can be ported as optional module |
Need to adopt {Rcpp} whenever possible.
inas_cell_df
in direction attachment (enhead
alternative)The text was updated successfully, but these errors were encountered: