Skip to content

Failure to compile v1.0-1 on macOS causing build error #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicholascarey opened this issue Jul 22, 2021 · 9 comments
Closed

Failure to compile v1.0-1 on macOS causing build error #1733

nicholascarey opened this issue Jul 22, 2021 · 9 comments

Comments

@nicholascarey
Copy link

nicholascarey commented Jul 22, 2021

Hi

A lack of a binary version of v1.0-1 and then failure to compile it on macOS is causing a build error on my R package. The log can be seen here

For a manual install I can choose "no" on the Do you want to install from sources the packages which need compilation? (Yes/no/cancel) prompt, in which case the v1.0-0 binary installs fine, but I've failed to find any option to set this as a default in, for instance, my package DESCRIPTION so that automatic builds or users do not encounter this problem.

sf is not a direct dependency, but is of several of my dependencies. I have tried adding sf as a specific dependency with the version sf (== 1.0-0) but this failed to work.

Perhaps I am missing a dependency that will allow v1.0-1 to be compiled ?

I'm not sure how to resolve this. Any advice would be welcome.

I realise this is probably related to this issue - #1703 - and gdal but the discussion there is far beyond my understanding.

By the way, v1.0-1 fails to compile on both my own development machine (an M1 Mac) and an Intel Mac, both on Big Sur.

Thanks

@rsbivand
Copy link
Member

rsbivand commented Jul 22, 2021

This is the same result as CRAN checks: https://www.r-project.org/nosvn/R.check/r-release-macos-arm64/sf-00install.html and https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/sf-00install.html. It is related to the deficiencies in generating the proj.pc file when building PROJ. If you can dig into how your process builds PROJ, it may be that an extra argument can be added to encourage it to yield a proj.pc that works. It may also be necessary to ensure that libsqlite3 etc. are visible to the sf configure step. The recipes for the CRAN software components are at https://github.com/R-macos/recipes. If your process does not use them, then please provide similar documentation, or only install binary versions from CRAN to stay with what works.

@edzer
Copy link
Member

edzer commented Jul 22, 2021

@rsbivand: it's related to this error message:

./configure: line 3769: Darwin: command not found

which results from an error in (my) configure.ac, and configure; now fixed in 1.0-2 (not yet on CRAN).

@rsbivand
Copy link
Member

OK, good that you tracked it down. I'll try to confirm, but that sounds sensible. So installing source from github should work.

@nicholascarey
Copy link
Author

Ok, great. Thanks. In other words sit tight and it will be resolved when this version is available?

Any idea of a rough timeline of when that might be? I'm planning my own submission of this to CRAN soon and hoping this won't hold it up.

If i understand this (at very bottom) correctly, I cannot have Github dependency remotes on submission to CRAN.

@edzer
Copy link
Member

edzer commented Jul 22, 2021

Pretty soon I hope, waiting for a report from @appelmar on whether my fix will work (there's no win-builder analogy for OSX)

@nicholascarey
Copy link
Author

Ok, thanks a lot.

@edzer
Copy link
Member

edzer commented Jul 26, 2021

1.0-2 is now on CRAN, OSX binaries typically follow after a few days...

@nicholascarey
Copy link
Author

Binary installed now on both M1 and Intel Macs, and no build errors in the package.
Thanks! 🥳

@edzer
Copy link
Member

edzer commented Jul 29, 2021

Thanks for reporting!

@edzer edzer closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants