Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about legacy package dependencies #738

Closed
dmkaplan2000 opened this issue Jun 19, 2023 · 4 comments
Closed

Warnings about legacy package dependencies #738

dmkaplan2000 opened this issue Jun 19, 2023 · 4 comments

Comments

@dmkaplan2000
Copy link

Hi,

I noticed that recent versions of tmap warn on load that there are dependencies on legacy packages sp, rgdal, etc. that are going away. I just wanted to make sure that these issues aren't going to impact core tmap functionality, i.e., that the package is going to stick around even if these dependencies disappear. I typically use tmap with sf and stars, so I wouldn't expect to be truly relying on any of these dependencies.

Thanks,
David

@mtennekes
Copy link
Member

Thx @dmkaplan2000
tmap does not use any of those packages anymore (already since 3.0). However, there are indirect dependencies that apparently still do.

@dmkaplan2000
Copy link
Author

Cool, thanks for letting me know.

@rsbivand
Copy link

For example:

library(tools)
pdb <- available.packages()
o1 <- package_dependencies(packages = c("tmap"), pdb, which = "strong", recursive = FALSE, reverse = FALSE)
"sp" %in% o1
# [1] FALSE
o2 <- package_dependencies(packages = o1$tmap, pdb, which = "strong", recursive = FALSE, reverse = FALSE)
sapply(o2, function(x) "sp" %in% x)
#      methods    tmaptools           sf        stars        units         grid 
#        FALSE        FALSE        FALSE        FALSE        FALSE        FALSE 
# RColorBrewer  viridisLite     classInt    htmltools  htmlwidgets  widgetframe 
#        FALSE        FALSE        FALSE        FALSE        FALSE        FALSE 
#      leaflet     leafsync       leafem        stats        abind        rlang 
#         TRUE        FALSE        FALSE        FALSE        FALSE        FALSE 
#        utils 
#       FALSE 

so it looks like leaflet.

@mtennekes
Copy link
Member

Thanks @rsbivand I saw that you already issued this rstudio/leaflet#833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants