Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky sidebar, fix issue #2 #9

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

Jasper-Mui
Copy link
Contributor

Story Title

make sidebar sticky #2

Changes made

  • add styling to Sider component to sticky sidebar
  • add a condition margin in the second layout component

How does the solution address the problem

This PR will make the sidebar is now sticky and the main content still adjust well when collapsing the sidebar

Linked issues

Resolves #2

@sloorush sloorush merged commit 90d44d9 into sloorush:master Oct 26, 2020
@sloorush
Copy link
Owner

Yay! Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sidebar sticky
2 participants