Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding locally workflow with API requests ON #537

Open
maciekbanas opened this issue Nov 12, 2024 · 0 comments
Open

Consider adding locally workflow with API requests ON #537

maciekbanas opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
continuous integration Continuous integration tests

Comments

@maciekbanas
Copy link
Member

Basically in #481 all responses have been mocked which makes tests and checks run faster, especially it is very convenient for PRs with GHA workflow. Still, there are used response fixtures all the way which makes big chunk of the workflow a bit artificial, as there is need sometimes to check/test the real situation.
The idea is then to prepare a local workflow which would switch on real API requests (at the beginning for example of GitHub get_commits tests), and propably switched off on GitHub and certainly on CRAN.

@maciekbanas maciekbanas self-assigned this Nov 12, 2024
@maciekbanas maciekbanas added tests continuous integration Continuous integration labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Continuous integration tests
Projects
None yet
Development

No branches or pull requests

1 participant