Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom window icon #635

Closed
Ksengine opened this issue Nov 2, 2020 · 10 comments
Closed

Set custom window icon #635

Ksengine opened this issue Nov 2, 2020 · 10 comments
Labels

Comments

@Ksengine
Copy link
Contributor

Ksengine commented Nov 2, 2020

Description

Feature Request
add method to set custom icon without freezers like pywebview

Practicalities

  • YES I am willing to work on this issue myself.

  • NO I am not prepared to support this issue financially.

@r0x0r
Copy link
Owner

r0x0r commented Nov 3, 2020

Aye, good idea. create_window(icon=icon_path) or something like that.

Some considerations

  1. No external libraries like pillow please
  2. Must be cross-platform
  3. Accepted icon formats at least png. I don't think there is a need to support platform specific icon formats like .ico or ICNS

@Ksengine
Copy link
Contributor Author

Ksengine commented Nov 4, 2020

Aye, good idea. create_window(icon=icon_path) or something like that.

icon is always a file path

@Ksengine
Copy link
Contributor Author

Ksengine commented Nov 4, 2020

question
can we extract the icon of currently loaded webpage

@Ksengine
Copy link
Contributor Author

  • Qt - window.setWindowIcon(QtGui.QIcon('icon.png'))

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 15, 2020
@github-actions
Copy link

The message to post on the issue when closing it. If none provided, will not comment when closing an issue.

@Ksengine
Copy link
Contributor Author

Dont close this issue

@OttomanZ
Copy link

@Ksengine I agree this should be an implemented feature, has this been implemented yet?

@r0x0r
Copy link
Owner

r0x0r commented Apr 28, 2023

There is a stale PR that implements this feature #786
The OP never addressed change requests. Feel free to continue.

@v479038280
Copy link

v479038280 commented Jul 19, 2024

Is there an example about set-icon? We couldn't use it if we install pywebview with the default dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants