Sinatra 3/4 compatibility? (Proposed gemspec change)

[voretaq7]

Looks like the gemspec for sinatra-r18n may be unnecessarily restrictive as '>= 1.3', '< 3'
This prevents the gem from being used in Sinatra 3 or Sinatra 4 applications.

sinatra-r18n appears to function correctly under noth Sinatra 3 and Sinatra 4 if I remove the <3 from the specification.
At least our internal tests are passing and strings are getting properly translated - if it's broken it's breaking outside my use case.

If there isn't a known issue or a deprecation of sinatra-r18n with later versions of Sinatra my life would be easier if the <3 restriction were loosened upstream. :-)

---

Steps to Reproduce

Simply require sinatra/r18n with Sinatra 3.x or 4.x as your default Sinatra version.

Expected Behavior

sinatra-r18n should load and operate normally.

Actual Behavior

Gem::ConflictError will be raised because of the sinatra-r18n gemspec requiring sinatra < 3.

Fix/Workaround

From our admittedly limited testing It appears safe to simply change the sinatra-r18n gemspec to require sinatra '>=1.3', '< 5' (maintaining a major version cap in case future major releases of Sinatra change functionality sinatra-r18n relies on).

Other Information

ruby -v:

ruby 3.2.4 (2024-04-23 revision af471c0e01) [amd64-freebsd14]

Relevant gems (off my test system):

rack (3.0.11)
sinatra (4.0.0)
sinatra-contrib (4.0.0)
sinatra-r18n (5.0.2)

[sergio-diaz-kaleris]

There is also this security vulnerability reported and the sinatra version with the fix 4.1.0, so every version allowed by this gem forces a vulnerable sinatra.

[voretaq7]

Oof. Makes it worse for sure!