Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand scope of BigDecimal testing. #209

Open
gregturn opened this issue Jan 12, 2022 · 1 comment
Open

Expand scope of BigDecimal testing. #209

gregturn opened this issue Jan 12, 2022 · 1 comment
Assignees
Labels
type: enhancement A general enhancement

Comments

@gregturn
Copy link
Contributor

H2 apparently supports the table types backing BigDecimal to also return NaN, +Inf, and -Inf, all types unsupported natively by BigDecimal. We need expanded testing and verification of handling this in a cohesive fashion.

@gregturn gregturn added the type: enhancement A general enhancement label Jan 12, 2022
@gregturn gregturn self-assigned this Jan 12, 2022
@gregturn gregturn added this to the 0.9.1.RELEASE milestone Jan 13, 2022
@katzyn
Copy link

katzyn commented Jan 29, 2022

REAL, DOUBLE PRECISION, FLOAT and DECFLOAT may have these special values in H2. FLOAT doesn't have an own implementation, it is mapped to REAL or DOUBLE PRECISION depending on declared scale. REAL values should normally be read and set as float or Float, DOUBLE PRECISION should normally be read and set as double or Double and they all support these values; so the only problematic type is DECFLOAT. It can be safely read as String, but people usually want to have a some numeric value. Therefore situation is complicated. BigDecimal doesn't support these special values, but it can hold all other values of DECFLOAT, unlike other numeric classes and primitive types from Java.

@gregturn gregturn modified the milestones: 0.9.1.RELEASE, 0.9.2 Feb 2, 2022
@gregturn gregturn modified the milestones: 0.9.2.RELEASE, 1.0.0-RC2 Jun 24, 2022
@gregturn gregturn removed this from the 1.0.0.RC2 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants