Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users management recipe does not manage tags #538

Closed
tophercullen opened this issue Oct 8, 2019 · 2 comments · Fixed by #539
Closed

Users management recipe does not manage tags #538

tophercullen opened this issue Oct 8, 2019 · 2 comments · Fixed by #539

Comments

@tophercullen
Copy link

tophercullen commented Oct 8, 2019

For the default users recipe, tag management appears to be the only user attribute not actively managed by the default user management recipe. The 'set-tags' is only called when the user is first created, or the password is change. Only changing an existing user's tags doesn't actually apply those tag changes.

This seems to be intentional, but its unclear to me why.

@michaelklishin
Copy link
Member

@tophercullen I don't know if it's intentional but it can be revisited. Please submit a PR that demonstrates what you'd do?

@tophercullen
Copy link
Author

tophercullen commented Oct 15, 2019

This is what I mean by intentional https://github.com/rabbitmq/chef-cookbook/blob/v5.x/recipes/users.rb#L38

The PR is simple, I don't mind submitting it. I just didn't want to take the time to do so, if there's a specific reason its written this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants