Skip to content

Set memory override value in RabbitMQ configuration #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zerpet opened this issue Oct 16, 2020 · 0 comments · Fixed by #403
Closed

Set memory override value in RabbitMQ configuration #392

Zerpet opened this issue Oct 16, 2020 · 0 comments · Fixed by #403
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Zerpet
Copy link
Member

Zerpet commented Oct 16, 2020

Is your feature request related to a problem?

The community RabbitMQ image in DockerHub sets the total memory available to the node in the entry point script, matching the memory defined by the cgroups. We want to stop relying on any behaviour that is implemented via this entry point script and make any relevant configuration part of the Operator configuration. This PR from rabbitmq-server delivered the ability to set the property total_memory_available_override_value to configure how much memory is available to RabbitMQ. By default, RabbitMQ will assume all the memory available in the current host. This becomes a problem in the context of containers because RabbitMQ will, incorrectly, assume that it has all the memory available in the host, however the memory will be limited by either cgroups or Kubernetes resource limits.

Describe the solution you'd like

Automatically configure the value of total_memory_available_override_value based on the value in .spec.resources.limits.memory. If this property is explicitly set to empty object i.e. unlimited, we will skip setting it and let the container assume it has all the memory available in the kubernetes node.

@Zerpet Zerpet added the enhancement New feature or request label Oct 16, 2020
@ChunyiLyu ChunyiLyu added this to the GA milestone Oct 20, 2020
@MirahImage MirahImage self-assigned this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants