Skip to content

Commit fa3dc12

Browse files
committed
A bit more special casing for Bazel
- Allow the ssl certs to be generated with make & openssl - Use the rabbitmq-run helper for starting/stopping the broker
1 parent f2ab274 commit fa3dc12

File tree

4 files changed

+41
-20
lines changed

4 files changed

+41
-20
lines changed

WORKSPACE.bazel

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ github_bazel_erlang_lib(
5252
version = "1.7.1",
5353
tag = "1.7.1",
5454
sha256 = "5607ea3b61fe8e715a1e711c5ce9000c8f16d4c2401c11318b76f65d11bf22d4",
55-
deps = [
56-
"@lager//:bazel_erlang_lib",
57-
],
55+
build_file = "@rabbitmq-server//:BUILD.ranch",
5856
)
5957

6058
github_bazel_erlang_lib(

src/rabbit_ct_broker_helpers.erl

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -727,17 +727,33 @@ do_start_rabbitmq_node(Config, NodeConfig, I) ->
727727
{"TEST_TMPDIR=~s", [PrivDir]}
728728
| ExtraArgs],
729729
Cmd = ["start-background-broker" | MakeVars],
730-
case rabbit_ct_helpers:make(Config, SrcDir, Cmd) of
731-
{ok, _} ->
732-
NodeConfig1 = rabbit_ct_helpers:set_config(
733-
NodeConfig,
734-
[{effective_srcdir, SrcDir},
735-
{make_vars_for_node_startup, MakeVars}]),
736-
query_node(Config, NodeConfig1);
737-
_ ->
738-
AbortCmd = ["stop-node" | MakeVars],
739-
_ = rabbit_ct_helpers:make(Config, SrcDir, AbortCmd),
740-
{skip, "Failed to initialize RabbitMQ"}
730+
case rabbit_ct_helpers:get_config(Config, rabbitmq_run_cmd) of
731+
undefined ->
732+
case rabbit_ct_helpers:make(Config, SrcDir, Cmd) of
733+
{ok, _} ->
734+
NodeConfig1 = rabbit_ct_helpers:set_config(
735+
NodeConfig,
736+
[{effective_srcdir, SrcDir},
737+
{make_vars_for_node_startup, MakeVars}]),
738+
query_node(Config, NodeConfig1);
739+
_ ->
740+
AbortCmd = ["stop-node" | MakeVars],
741+
_ = rabbit_ct_helpers:make(Config, SrcDir, AbortCmd),
742+
{skip, "Failed to initialize RabbitMQ"}
743+
end;
744+
RunCmd ->
745+
case rabbit_ct_helpers:exec([RunCmd | Cmd]) of
746+
{ok, _} ->
747+
NodeConfig1 = rabbit_ct_helpers:set_config(
748+
NodeConfig,
749+
[{effective_srcdir, SrcDir},
750+
{make_vars_for_node_startup, MakeVars}]),
751+
query_node(Config, NodeConfig1);
752+
_ ->
753+
AbortCmd = ["stop-node" | MakeVars],
754+
_ = rabbit_ct_helpers:exec([RunCmd | AbortCmd]),
755+
{skip, "Failed to initialize RabbitMQ"}
756+
end
741757
end.
742758

743759
query_node(Config, NodeConfig) ->

src/rabbit_ct_helpers.erl

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ run_setup_steps(Config, ExtraSteps) ->
9191
[
9292
fun init_skip_as_error_flag/1,
9393
% fun guess_tested_erlang_app_name/1,
94-
% fun ensure_rabbitmq_ct_helpers_srcdir/1,
95-
fun ensure_fake_make_cmd/1,
96-
% fun ensure_ssl_certs/1,
94+
fun ensure_rabbitmq_ct_helpers_srcdir/1,
95+
fun ensure_make_cmd/1,
96+
fun ensure_rabbitmq_run_cmd/1,
97+
fun ensure_ssl_certs/1,
9798
fun start_long_running_testsuite_monitor/1
9899
]
99100
end,
@@ -347,12 +348,14 @@ ensure_make_cmd(Config) ->
347348
"please set MAKE or 'make_cmd' in ct config"}
348349
end.
349350

350-
ensure_fake_make_cmd(Config) ->
351+
ensure_rabbitmq_run_cmd(Config) ->
351352
case os:getenv("RABBITMQ_RUN") of
352353
false ->
353-
{skip, "Bazel build env required"};
354+
{skip,
355+
"Bazel helper rabbitmq-run required, " ++
356+
"please set RABBITMQ_RUN"};
354357
P ->
355-
set_config(Config, {make_cmd, P})
358+
set_config(Config, {rabbitmq_run_cmd, P})
356359
end.
357360

358361
ensure_erl_call_cmd(Config) ->

tools/tls-certs/BUILD.bazel

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
exports_files([
2+
"Makefile",
3+
"openssl.cnf.in",
4+
])

0 commit comments

Comments
 (0)