* Encode publish sequence number in x-dotnet-pub-seq-no as a long instead of ASCII string.

Author: lukebakken

projects/Applications/PublisherConfirms/PublisherConfirms.cs

@@ -54,7 +54,7 @@
     Persistent = true
 };
 
-string hostname = "localhost";
+string hostname = "shostakovich";
 if (args.Length > 0)
 {
     if (false == string.IsNullOrWhiteSpace(args[0]))
@@ -278,29 +278,21 @@ async Task CleanOutstandingConfirms(ulong deliveryTag, bool multiple)
 
     channel.BasicReturnAsync += (sender, ea) =>
     {
-        string sequenceNumber = string.Empty;
+        ulong sequenceNumber = 0;
 
         IReadOnlyBasicProperties props = ea.BasicProperties;
         if (props.Headers is not null)
         {
             object? maybeSeqNum = props.Headers[Constants.PublishSequenceNumberHeader];
-            if (maybeSeqNum is not null)
+            if (maybeSeqNum is long longSequenceNumber)
             {
-                switch (maybeSeqNum)
-                {
-                    case byte[] seqNumBytes:
-                        sequenceNumber = Encoding.ASCII.GetString(seqNumBytes);
-                        break;
-                    case string seqNumStr:
-                        sequenceNumber = seqNumStr;
-                        break;
-                }
+                sequenceNumber = (ulong)longSequenceNumber;
             }
         }
 
         Console.WriteLine($"{DateTime.Now} [INFO] message sequence number '{sequenceNumber}' has been basic.return-ed");
-        ulong seq = ulong.Parse(sequenceNumber);
-        return CleanOutstandingConfirms(seq, false);
+
+        return CleanOutstandingConfirms(sequenceNumber, false);
     };
 
     channel.BasicAcksAsync += (sender, ea) => CleanOutstandingConfirms(ea.DeliveryTag, ea.Multiple);
@@ -346,7 +338,7 @@ async Task CleanOutstandingConfirms(ulong deliveryTag, bool multiple)
             Headers = new Dictionary<string, object?>()
         };
 
-        msgProps.Headers.Add(Constants.PublishSequenceNumberHeader, nextPublishSeqNo.ToString());
+        msgProps.Headers.Add(Constants.PublishSequenceNumberHeader, (long)nextPublishSeqNo);
 
         (ulong, ValueTask) data =
             (nextPublishSeqNo, channel.BasicPublishAsync(exchange: string.Empty, routingKey: rk, body: body, mandatory: true, basicProperties: msgProps));

projects/RabbitMQ.Client/Impl/Channel.BasicPublish.cs

@@ -216,7 +216,14 @@ void MaybeAddPublishSequenceNumberToHeaders(IDictionary<string, object?> headers
             {
                 if (_publisherConfirmationsEnabled && _publisherConfirmationTrackingEnabled)
                 {
-                    headers[Constants.PublishSequenceNumberHeader] = publishSequenceNumber.ToString();
+                    if (publishSequenceNumber > long.MaxValue)
+                    {
+                        headers[Constants.PublishSequenceNumberHeader] = publishSequenceNumber.ToString();
+                    }
+                    else
+                    {
+                        headers[Constants.PublishSequenceNumberHeader] = (long)publishSequenceNumber;
+                    }
                 }
             }
         }

projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs

@@ -237,6 +237,9 @@ private void HandleReturn(BasicReturnEventArgs basicReturnEvent)
                 {
                     switch (maybeSeqNum)
                     {
+                        case long seqNumLong:
+                            publishSequenceNumber = (ulong)seqNumLong;
+                            break;
                         case string seqNumString:
                             publishSequenceNumber = ulong.Parse(seqNumString);
                             break;