Merge pull request #936 from bollhals/useSpanDirectly

Use span directly instead of reader / writer for methods & properties

Author: michaelklishin

RabbitMQDotNetClient.sln

@@ -12,6 +12,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.Client", "projects
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Unit", "projects\Unit\Unit.csproj", "{B8FAC024-CC03-4067-9FFC-02846FB8AE48}"
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Benchmarks", "projects\Benchmarks\Benchmarks.csproj", "{38D72C9A-68E9-4653-B0CE-C7BA9FFD91D0}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -26,6 +28,10 @@ Global
 		{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.Build.0 = Release|Any CPU
+		{38D72C9A-68E9-4653-B0CE-C7BA9FFD91D0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{38D72C9A-68E9-4653-B0CE-C7BA9FFD91D0}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{38D72C9A-68E9-4653-B0CE-C7BA9FFD91D0}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{38D72C9A-68E9-4653-B0CE-C7BA9FFD91D0}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

projects/Benchmarks/Benchmarks.csproj

@@ -0,0 +1,18 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile>
+    <SignAssembly>true</SignAssembly>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="BenchmarkDotNet" Version="0.12.1" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\RabbitMQ.Client\RabbitMQ.Client.csproj" />
+  </ItemGroup>
+
+</Project>

projects/Benchmarks/Program.cs

@@ -0,0 +1,12 @@
+using BenchmarkDotNet.Running;
+
+namespace Benchmarks
+{
+    public static class Program
+    {
+        public static void Main(string[] args)
+        {
+            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Read_BasicAck.cs

@@ -0,0 +1,24 @@
+using System;
+using BenchmarkDotNet.Attributes;
+using RabbitMQ.Client.Framing.Impl;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Read_BasicAck
+    {
+        private readonly byte[] _buffer = new byte[1024];
+
+        public WireFormatting_Read_BasicAck()
+        {
+            new BasicAck(ulong.MaxValue, true).WriteArgumentsTo(_buffer);
+        }
+
+        [Benchmark(Baseline = true)]
+        public object ReadFromSpan()
+        {
+            return new BasicAck(new ReadOnlySpan<byte>(_buffer));
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Read_BasicDeliver.cs

@@ -0,0 +1,24 @@
+using System;
+using BenchmarkDotNet.Attributes;
+using BasicDeliver = RabbitMQ.Client.Framing.Impl.BasicDeliver;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Read_BasicDeliver
+    {
+        private readonly byte[] _buffer = new byte[1024];
+
+        public WireFormatting_Read_BasicDeliver()
+        {
+            new BasicDeliver(string.Empty, 0, false, string.Empty, string.Empty).WriteArgumentsTo(_buffer);
+        }
+
+        [Benchmark(Baseline = true)]
+        public object ReadFromSpan()
+        {
+            return new BasicDeliver(new ReadOnlySpan<byte>(_buffer));
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Read_BasicProperties.cs

@@ -0,0 +1,29 @@
+using System;
+using BenchmarkDotNet.Attributes;
+using BasicProperties = RabbitMQ.Client.Framing.BasicProperties;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Read_BasicProperties
+    {
+        private readonly byte[] _buffer = new byte[1024];
+
+        public WireFormatting_Read_BasicProperties()
+        {
+            new BasicProperties
+            {
+                Persistent = true,
+                AppId = "AppId",
+                ContentEncoding = "content"
+            }.WritePropertiesTo(_buffer);
+        }
+
+        [Benchmark(Baseline = true)]
+        public object ReadFromSpan()
+        {
+            return new BasicProperties(new ReadOnlySpan<byte>(_buffer));
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Read_ChannelClose.cs

@@ -0,0 +1,24 @@
+using System;
+using BenchmarkDotNet.Attributes;
+using RabbitMQ.Client.Framing.Impl;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Read_ChannelClose
+    {
+        private readonly byte[] _buffer = new byte[1024];
+
+        public WireFormatting_Read_ChannelClose()
+        {
+            new ChannelClose(333, string.Empty,  0099, 2999).WriteArgumentsTo(_buffer);
+        }
+
+        [Benchmark(Baseline = true)]
+        public object ReadFromSpan()
+        {
+            return new ChannelClose(new ReadOnlySpan<byte>(_buffer));
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Write_BasicAck.cs

@@ -0,0 +1,19 @@
+using BenchmarkDotNet.Attributes;
+using RabbitMQ.Client.Framing.Impl;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Write_BasicAck
+    {
+        private readonly byte[] _buffer = new byte[1024];
+        private readonly BasicAck _method = new BasicAck(ulong.MaxValue, true);
+
+        [Benchmark(Baseline = true)]
+        public int WriteArgumentsTo()
+        {
+            return _method.WriteArgumentsTo(_buffer);
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Write_BasicDeliver.cs

@@ -0,0 +1,19 @@
+using BenchmarkDotNet.Attributes;
+using BasicDeliver = RabbitMQ.Client.Framing.Impl.BasicDeliver;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Write_BasicDeliver
+    {
+        private readonly byte[] _buffer = new byte[1024];
+        private readonly BasicDeliver _method = new BasicDeliver(string.Empty, 0, false, string.Empty, string.Empty);
+
+        [Benchmark(Baseline = true)]
+        public int WriteArgumentsTo()
+        {
+            return _method.WriteArgumentsTo(_buffer);
+        }
+    }
+}

projects/Benchmarks/WireFormatting/WireFormatting_Write_BasicProperties.cs

@@ -0,0 +1,25 @@
+using System;
+using BenchmarkDotNet.Attributes;
+using BasicProperties = RabbitMQ.Client.Framing.BasicProperties;
+
+namespace Benchmarks.WireFormatting
+{
+    [ShortRunJob]
+    [MemoryDiagnoser]
+    public class WireFormatting_Write_BasicProperties
+    {
+        private readonly byte[] _buffer = new byte[1024];
+        private readonly BasicProperties _properties = new BasicProperties
+        {
+            Persistent = true,
+            AppId = "AppId",
+            ContentEncoding = "content",
+        };
+
+        [Benchmark(Baseline = true)]
+        public void WritePropertiesToSpan()
+        {
+            _properties.WritePropertiesTo(new Span<byte>(_buffer));
+        }
+    }
+}