Investigate the use of TaskCreationOptions.LongRunning

[lukebakken]

Reported here:

https://groups.google.com/g/rabbitmq-users/c/9lFwM_xF5cw

Relevant discussion:

#959

[stebet]

It's not that simple. Task.Factory.StartNew does not support async methods which MainLoop will become eventually.

[lukebakken]

I figured there was a reason we're not using it.

@stebet for 6.x I'm assuming it's fine to make this change.

[d-jagoda]

I believe it was conditionally used before but was removed by commit 311ef63

As for using async methods in Task.Factory.StartNew, it is possible to use them, you just have to unwrap the result task no? Which is exactly what Task.Run with async methods to. So it would be no different from using Task.Run except for minor differences which can be changed via TaskCreationOptions.

        var task = Task.Factory.StartNew(async () =>
        {
            await Task.Delay(TimeSpan.FromSeconds(10));
        });

        await task.Unwrap();
        // Or
        // var inner = await task;
        // await inner;

[Zerpet]

I figured there was a reason we're not using it.

@stebet for 6.x I'm assuming it's fine to make this change.

I'll be happy to keep this change for the 6.x branch, assuming it is not breaking change (as marked in #1321)

[d-jagoda]

I figured there was a reason we're not using it.
@stebet for 6.x I'm assuming it's fine to make this change.

I'll be happy to keep this change for the 6.x branch, assuming it is not breaking change (as marked in #1321)

Thanks, that will be great. I've unmarked it as breaking now.

I only marked it as breaking because there is a minor "observable behavior change in existing systems" where the task no longer runs on the threadpool.

[lukebakken]

Fixed by #1321

[lukebakken]

@d-jagoda

• https://github.com/rabbitmq/rabbitmq-dotnet-client/releases/tag/v6.5.0
• https://www.nuget.org/packages/RabbitMQ.Client/6.5.0