Only throw RabbitMQ.Client-specific exceptions.

[paulomorgado]

Describe the bug

From Using Standard Exception Types:

❌ DO NOT throw System.Exception or System.SystemException.

RabbitMQ code should return RabbitMQ exceptions. If there was another exception causing the one being thrown, it should be added as an InnerException.

Reproduction steps

ServiceBase.Notify is throwing System.Exception at https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/impl/SessionBase.cs#L128

Expected behavior

a RabbitMQ-specific exception is thrown.

Additional context

No response

[lukebakken]

Thank you @paulomorgado for taking the time to open this issue with great details.

Relevant comments - 169a6d1#r134239817

[lukebakken]

Exceptions thrown by this library could include the associated connection and channel as exception data to allow library users to take appropriate action. Thoughts? @paulomorgado

[paulomorgado]

All the information that can be provided is always helpful.

Exceptions have a Data property that can be used to add information.

But this is not very discoverable and people usually choose to add the data as custome exception properties.

If you are creating scenario specific exceptions, you can create properties for that.

But I wouldn't mind having them as data.

[lukebakken]

Closing! See this comment.