AmqpTcpEndpoint.ToString() does not report a Uri scheme of "amqps" although SslOption is enabled

[ghost]

AmqpTcpEndpoint.ToString() should correctly report a Uri scheme of amqps whenever its SSLOption is enabled.

From AmqpTcpEndpoint.cs, line 282 ff.:

        /// <summary>
        /// Returns a URI-like string of the form amqp-PROTOCOL://HOSTNAME:PORTNUMBER.
        /// </summary>
        /// <remarks>
        /// This method is intended mainly for debugging and logging use.
        /// </remarks>
        public override string ToString()
        {
            return $"amqp://{HostName}:{Port}";
        }

Compare this to the implementation of ConnectionFactory.SetUri(...) ConnectionFactory.cs, line 531 ff. where an Uri scheme of amqps is correctly interpreted to initialize the SSLOption:

        private void SetUri(Uri uri)
        {
            Endpoint = new AmqpTcpEndpoint();

            if (string.Equals("amqp", uri.Scheme, StringComparison.OrdinalIgnoreCase))
            {
                // nothing special to do
            }
            else if (string.Equals("amqps", uri.Scheme, StringComparison.OrdinalIgnoreCase))
            {
                Ssl.Enabled = true;
                Ssl.Version = AmqpUriSslProtocols;
                Ssl.AcceptablePolicyErrors = SslPolicyErrors.RemoteCertificateNameMismatch;
                Port = AmqpTcpEndpoint.DefaultAmqpSslPort;
            }
            else
            {
                throw new ArgumentException($"Wrong scheme in AMQP URI: {uri.Scheme}");
            }

[michaelklishin]

This is open source software. If you understand what exactly should be changed and why, please submit a pull request and it will be considered.

[lukebakken]

Fixed by #864