Clarify the noAck parameter of BasicConsume

[jeremyVignelles]

When following the tutorial, I came across this line:

Message acknowledgments are turned on by default. In previous examples we explicitly turned them off by setting the noAck ("no manual acks") parameter to true. It's time to remove this flag and send a proper acknowledgment from the worker, once we're done with a task.

This really bugs me. Indeed, the noAck option was set to true on the first example, but this option enables the acknowledgment instead of disabling it.

When looking for the documentation, I found the java equivalent to this function, where the parameter is named autoAck

• The parameter should be named autoAck, to keep aligned with the Java client
• The default value should be set to true
• The documentation should be updated.

[michaelklishin]

We won't be changing the default value but it was renamed in at least Java and Ruby clients (Bunny), so it makes sense.

What documentation specifically needs updating?

[jeremyVignelles]

The documentations that are using the BasicConsume method, so basically each consumer source codes.
There is also the quoted paragraph that is taken from the C# tutorial, part II.

This name change is breaking for the users that followed the tutorial and used the named parameter explicitely, so I would suggest to make this change in the next major release.

[michaelklishin]

@jeremyVignelles can you please be more specific? Links to rabbitmq.com doc pages or GitHub source files would be sufficient ;)

[jeremyVignelles]

http://www.rabbitmq.com/tutorials/tutorial-one-dotnet.html
http://www.rabbitmq.com/tutorials/tutorial-two-dotnet.html
http://www.rabbitmq.com/tutorials/tutorial-three-dotnet.html
http://www.rabbitmq.com/tutorials/tutorial-four-dotnet.html
http://www.rabbitmq.com/tutorials/tutorial-five-dotnet.html
http://www.rabbitmq.com/tutorials/tutorial-six-dotnet.html

(look for "BasicConsume(")

• http://www.rabbitmq.com/tutorials/tutorial-two-dotnet.html at the paragraph that is quoted in my first post. "Message acknowledgments are turned on by default[...]"

[maxima120]

noAck option was set to true on the first example, but this option enables the acknowledgment instead of disabling it.

so if I had noAck = true in previous version, does this mean I keep it the same ? autoAck = true ?

[jeremyVignelles]

If this is just a rename, as this issue asked for, then yes, noAck = true translates to autoAck = true

[maxima120]

I am checking in into the production.. so id like to know for sure :)

[michaelklishin]

noAck means "no manual acknowledgements", so, automatic mode.

[InsOpDe]

I find autoAck more comprehensible than noAck, as noAck could also mean that messages should not / cannot be ack'ed.