Skip to content

Commit 9601a5a

Browse files
Merge pull request #4 from rabbitmq/rabbitmq-event-exchange-10
Notify user who performed the action where needed
2 parents 6170ac4 + 90e8f5b commit 9601a5a

File tree

1 file changed

+83
-19
lines changed

1 file changed

+83
-19
lines changed

deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl

Lines changed: 83 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@
6363
get_queue_sup_pid/1,
6464

6565
set_policy/6,
66+
set_policy/7,
6667
clear_policy/3,
68+
clear_policy/4,
6769
set_operator_policy/6,
6870
clear_operator_policy/3,
6971
set_ha_policy/4, set_ha_policy/5,
@@ -73,8 +75,10 @@
7375

7476
set_parameter/5,
7577
set_parameter/6,
78+
set_parameter/7,
7679
clear_parameter/4,
7780
clear_parameter/5,
81+
clear_parameter/6,
7882

7983
set_global_parameter/3,
8084
set_global_parameter/4,
@@ -83,16 +87,24 @@
8387

8488
add_vhost/2,
8589
add_vhost/3,
90+
add_vhost/4,
8691
delete_vhost/2,
8792
delete_vhost/3,
93+
delete_vhost/4,
8894

8995
add_user/2,
9096
add_user/3,
9197
add_user/4,
98+
add_user/5,
9299
set_user_tags/4,
100+
set_user_tags/5,
93101

94102
delete_user/2,
95103
delete_user/3,
104+
delete_user/4,
105+
106+
change_password/5,
107+
clear_password/4,
96108

97109
change_password/3,
98110

@@ -101,13 +113,15 @@
101113

102114
set_permissions/6,
103115
set_permissions/7,
116+
set_permissions/8,
104117
set_full_permissions/2,
105118
set_full_permissions/3,
106119
set_full_permissions/4,
107120

108121
clear_permissions/2,
109122
clear_permissions/3,
110123
clear_permissions/4,
124+
clear_permissions/5,
111125

112126
enable_plugin/3,
113127
disable_plugin/3,
@@ -800,13 +814,19 @@ add_vhost(Config, VHost) ->
800814
add_vhost(Config, 0, VHost).
801815

802816
add_vhost(Config, Node, VHost) ->
803-
rpc(Config, Node, rabbit_vhost, add, [VHost]).
817+
add_vhost(Config, Node, VHost, <<"acting-user">>).
818+
819+
add_vhost(Config, Node, VHost, Username) ->
820+
rabbit_ct_broker_helpers:rpc(Config, Node, rabbit_vhost, add, [VHost, Username]).
804821

805822
delete_vhost(Config, VHost) ->
806823
delete_vhost(Config, 0, VHost).
807824

808825
delete_vhost(Config, Node, VHost) ->
809-
rpc(Config, Node, rabbit_vhost, delete, [VHost]).
826+
delete_vhost(Config, Node, VHost, <<"acting-user">>).
827+
828+
delete_vhost(Config, Node, VHost, Username) ->
829+
rabbit_ct_broker_helpers:rpc(Config, Node, rabbit_vhost, delete, [VHost, Username]).
810830

811831
add_user(Config, Username) ->
812832
%% for many tests it is convenient that
@@ -817,23 +837,41 @@ add_user(Config, Username, Password) ->
817837
add_user(Config, 0, Username, Password).
818838

819839
add_user(Config, Node, Username, Password) ->
820-
rpc(Config, Node, rabbit_auth_backend_internal, add_user,
840+
add_user(Config, Node, Username, Password, <<"acting-user">>).
841+
842+
add_user(Config, Node, Username, Password, AuditUsername) ->
843+
rabbit_ct_broker_helpers:rpc(Config, Node, rabbit_auth_backend_internal, add_user,
821844
[rabbit_data_coercion:to_binary(Username),
822-
rabbit_data_coercion:to_binary(Password)]).
845+
rabbit_data_coercion:to_binary(Password),
846+
AuditUsername]).
823847

824848
set_user_tags(Config, Node, Username, Tags) ->
825-
rabbit_ct_broker_helpers:rpc(Config, Node, rabbit_auth_backend_internal, set_tags, [Username, Tags]).
849+
set_user_tags(Config, Node, Username, Tags, <<"acting-user">>).
850+
851+
set_user_tags(Config, Node, Username, Tags, AuditUsername) ->
852+
rabbit_ct_broker_helpers:rpc(Config, Node, rabbit_auth_backend_internal, set_tags,
853+
[Username, Tags, AuditUsername]).
826854

827855
delete_user(Config, Username) ->
828856
delete_user(Config, 0, Username).
829857

830858
delete_user(Config, Node, Username) ->
831-
rpc(Config, Node, rabbit_auth_backend_internal, delete_user, [Username]).
859+
delete_user(Config, Node, Username, <<"acting-user">>).
860+
861+
delete_user(Config, Node, Username, AuditUsername) ->
862+
rpc(Config, Node, rabbit_auth_backend_internal, delete_user,
863+
[Username, AuditUsername]).
832864

833865
change_password(Config, Username, Password) ->
834-
rpc(Config, 0,
835-
rabbit_auth_backend_internal, change_password, [Username, Password]).
866+
change_password(Config, 0, Username, Password, <<"acting-user">>).
836867

868+
change_password(Config, Node, Username, Password, AuditUsername) ->
869+
rpc(Config, Node, rabbit_auth_backend_internal, change_password,
870+
[Username, Password, AuditUsername]).
871+
872+
clear_password(Config, Node, Username, AuditUsername) ->
873+
rpc(Config, Node, rabbit_auth_backend_internal, clear_password,
874+
[Username, AuditUsername]).
837875

838876
switch_credential_validator(Config, accept_everything) ->
839877
rpc(Config, 0, application, set_env,
@@ -868,26 +906,38 @@ set_full_permissions(Config, Node, Username, VHost) ->
868906

869907
set_permissions(Config, Username, VHost, ConfigurePerm, WritePerm, ReadPerm) ->
870908
set_permissions(Config, 0, Username, VHost, ConfigurePerm, WritePerm, ReadPerm).
909+
871910
set_permissions(Config, Node, Username, VHost, ConfigurePerm, WritePerm, ReadPerm) ->
911+
set_permissions(Config, Node, Username, VHost, ConfigurePerm, WritePerm, ReadPerm,
912+
<<"acting-user">>).
913+
914+
set_permissions(Config, Node, Username, VHost, ConfigurePerm, WritePerm, ReadPerm,
915+
ActingUser) ->
872916
rabbit_ct_broker_helpers:rpc(Config, Node,
873917
rabbit_auth_backend_internal,
874918
set_permissions,
875919
[rabbit_data_coercion:to_binary(Username),
876920
rabbit_data_coercion:to_binary(VHost),
877921
rabbit_data_coercion:to_binary(ConfigurePerm),
878922
rabbit_data_coercion:to_binary(WritePerm),
879-
rabbit_data_coercion:to_binary(ReadPerm)]).
923+
rabbit_data_coercion:to_binary(ReadPerm),
924+
ActingUser]).
880925

881926
clear_permissions(Config, VHost) ->
882927
clear_permissions(Config, 0, <<"guest">>, VHost).
883928
clear_permissions(Config, Username, VHost) ->
884929
clear_permissions(Config, 0, Username, VHost).
930+
885931
clear_permissions(Config, Node, Username, VHost) ->
932+
clear_permissions(Config, Node, Username, VHost, <<"acting-user">>).
933+
934+
clear_permissions(Config, Node, Username, VHost, ActingUser) ->
886935
rabbit_ct_broker_helpers:rpc(Config, Node,
887936
rabbit_auth_backend_internal,
888937
clear_permissions,
889938
[rabbit_data_coercion:to_binary(Username),
890-
rabbit_data_coercion:to_binary(VHost)]).
939+
rabbit_data_coercion:to_binary(VHost),
940+
ActingUser]).
891941

892942

893943
%% Functions to execute code on a remote node/broker.
@@ -1061,20 +1111,28 @@ get_queue_sup_pid([], _QueuePid) ->
10611111
%% -------------------------------------------------------------------
10621112

10631113
set_policy(Config, Node, Name, Pattern, ApplyTo, Definition) ->
1114+
set_policy(Config, Node, Name, Pattern, ApplyTo, Definition, <<"acting-user">>).
1115+
1116+
set_policy(Config, Node, Name, Pattern, ApplyTo, Definition, Username) ->
10641117
ok = rpc(Config, Node,
1065-
rabbit_policy, set, [<<"/">>, Name, Pattern, Definition, 0, ApplyTo]).
1118+
rabbit_policy, set, [<<"/">>, Name, Pattern, Definition, 0, ApplyTo,
1119+
Username]).
10661120

10671121
clear_policy(Config, Node, Name) ->
1122+
clear_policy(Config, Node, Name, <<"acting-user">>).
1123+
1124+
clear_policy(Config, Node, Name, Username) ->
10681125
rpc(Config, Node,
1069-
rabbit_policy, delete, [<<"/">>, Name]).
1126+
rabbit_policy, delete, [<<"/">>, Name, Username]).
10701127

10711128
set_operator_policy(Config, Node, Name, Pattern, ApplyTo, Definition) ->
10721129
ok = rpc(Config, Node,
1073-
rabbit_policy, set_op, [<<"/">>, Name, Pattern, Definition, 0, ApplyTo]).
1130+
rabbit_policy, set_op, [<<"/">>, Name, Pattern, Definition, 0, ApplyTo,
1131+
<<"acting-user">>]).
10741132

10751133
clear_operator_policy(Config, Node, Name) ->
10761134
rpc(Config, Node,
1077-
rabbit_policy, delete_op, [<<"/">>, Name]).
1135+
rabbit_policy, delete_op, [<<"/">>, Name, <<"acting-user">>]).
10781136

10791137
set_ha_policy(Config, Node, Pattern, Policy) ->
10801138
set_ha_policy(Config, Node, Pattern, Policy, []).
@@ -1121,30 +1179,36 @@ set_ha_policy_two_pos_batch_sync(Config) ->
11211179
%% -------------------------------------------------------------------
11221180

11231181
set_parameter(Config, Node, Component, Name, Value) ->
1124-
set_parameter(Config, Node, <<"/">>, Component, Name, Value).
1182+
set_parameter(Config, Node, <<"/">>, Component, Name, Value, none).
11251183

11261184
set_parameter(Config, Node, VHost, Component, Name, Value) ->
1185+
set_parameter(Config, Node, VHost, Component, Name, Value, none).
1186+
1187+
set_parameter(Config, Node, VHost, Component, Name, Value, Username) ->
11271188
ok = rpc(Config, Node,
1128-
rabbit_runtime_parameters, set, [VHost, Component, Name, Value, none]).
1189+
rabbit_runtime_parameters, set, [VHost, Component, Name, Value, Username]).
11291190

11301191
clear_parameter(Config, Node, Component, Name) ->
11311192
clear_parameter(Config, Node, <<"/">>, Component, Name).
11321193

11331194
clear_parameter(Config, Node, VHost, Component, Name) ->
1195+
clear_parameter(Config, Node, VHost, Component, Name, <<"acting-user">>).
1196+
1197+
clear_parameter(Config, Node, VHost, Component, Name, Username) ->
11341198
ok = rpc(Config, Node,
1135-
rabbit_runtime_parameters, clear, [VHost, Component, Name]).
1199+
rabbit_runtime_parameters, clear, [VHost, Component, Name, Username]).
11361200

11371201
set_global_parameter(Config, Name, Value) ->
11381202
set_global_parameter(Config, 0, Name, Value).
11391203
set_global_parameter(Config, Node, Name, Value) ->
11401204
ok = rpc(Config, Node,
1141-
rabbit_runtime_parameters, set_global, [Name, Value]).
1205+
rabbit_runtime_parameters, set_global, [Name, Value, <<"acting-user">>]).
11421206

11431207
clear_global_parameter(Config, Name) ->
11441208
clear_global_parameter(Config, 0, Name).
11451209
clear_global_parameter(Config, Node, Name) ->
11461210
ok = rpc(Config, Node,
1147-
rabbit_runtime_parameters, clear_global, [Name]).
1211+
rabbit_runtime_parameters, clear_global, [Name, <<"acting-user">>]).
11481212

11491213
%% -------------------------------------------------------------------
11501214
%% Parameter helpers.

0 commit comments

Comments
 (0)