Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should virtual host-specific definition import exclude virtual host name? #10078

Closed
michaelklishin opened this issue Dec 8, 2023 · 2 comments
Assignees
Milestone

Comments

@michaelklishin
Copy link
Member

See #10068 for the background.

During that investigation we have learnt that in early 2016 in 8ba0e07 a decision was to exclude the vhost field when exporting definitions of a single virtual host. I don't remember the details but the goal
could have been to allow for such files to be imported into any virtual host in a different cluster.

We can restore the vhost field to avoid the confusing scenario in #10068 and possibly ignore it during the import operation.

@michaelklishin
Copy link
Member Author

Discussed this one more time as part of my work on #12821. This is something we can change for 4.1.0.

@michaelklishin
Copy link
Member Author

We have made a decision. Per discussion with @mkuratczyk:

  1. Being able to import a single virtual host into another one in a different cluster and with a different name has its benefits
  2. We can add some metadata to the definitions to help determine the definition file "type" (cluster-wide definitions vs. single virtual host definitions)
  3. We can produce a better error message on boot

and keep everything as is, plus backwards compatible for existing deployment and practices, which is also very valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants