Skip to content

Logging upgrade category output to stdout #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukebakken opened this issue May 11, 2022 · 3 comments
Closed

Logging upgrade category output to stdout #4792

lukebakken opened this issue May 11, 2022 · 3 comments

Comments

@lukebakken
Copy link
Collaborator

Prior to #4303, setting RABBITMQ_LOGS=- would also send the upgrade log file to stdout.

We should allow using configuration entries like this:

log.upgrade.file = -
log.upgrade.file = stdout

This should also be valid for the other log files.

@michaelklishin
Copy link
Collaborator

The example here folds categories and targets together. Should we start with figuring out why the upgrade category doesn't inherit the default target? I'd expect most environments to choose
to either log everything into files, or everything to standard streams, or everything to Syslog.

@dumbbell
Copy link
Collaborator

dumbbell commented May 11, 2022

This upgrade log file was kept when RabbitMQ was switched to Lager. To support this, there is a special configuration in RabbitMQ just for this category. I would be in favor of getting rid of this legacy and treat it like other categories. It would mean that the default log file would be used out-of-the-box for upgrade logs. Perhaps there is something special with upgrades that I don't picture which is better served with a dedicated log file though.

@michaelklishin michaelklishin changed the title Allow setting upgrade log file output to stdout Logging upgrade category output to stdout May 13, 2022
@lukebakken
Copy link
Collaborator Author

This issue has been rendered moot by @dumbbell's PR - #5415

@lukebakken lukebakken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants