Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS open instead of xdg-open #95

Open
thezealousfool opened this issue May 28, 2020 · 1 comment · May be fixed by #88
Open

MacOS open instead of xdg-open #95

thezealousfool opened this issue May 28, 2020 · 1 comment · May be fixed by #88
Assignees
Labels
bug Something isn't working

Comments

@thezealousfool
Copy link

In MacOS, the open command is used in the place of xdg-open. I see the xdg-open command has been hard coded in file_browser.rs. Possible solutions include -

  1. A configuration option to allow the user set any custom command to open files by default
  2. Detect OS to be Mac at build time and replace xdg-open with open
@rabite0
Copy link
Owner

rabite0 commented May 28, 2020

There's a pull request to make the opener configurable. I'm waiting on the author to respond to my suggested changes, but I might just pull and fix it up myself.

The default should probably not be hard-coded either, but depend on the OS and what's available on the system. Doesn't have to be a compile time thing, it could just check for (xdg)-open, ranger's rifle and maybe others and use what's available by setting it as default option if no opener was set explicitly.

@rabite0 rabite0 self-assigned this May 28, 2020
@rabite0 rabite0 added the bug Something isn't working label May 28, 2020
@rabite0 rabite0 linked a pull request May 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants