Skip to content

Commit 42fae31

Browse files
authored
Merge pull request #132 from rackerlabs/issue-131-remove-requirement-for-targets-and_excluded_targets-when-using-api
Removed requirement for both targets and excluded_targets when using API
2 parents 6a09409 + f8446a1 commit 42fae31

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

master/django_scantron/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "1.9"
1+
__version__ = "1.10"

master/django_scantron/api/serializers.py

+14-12
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,26 @@ def validate(self, attrs):
3636
"""Checks for any invalid IPs, IP subnets, or FQDNs in the targets or excluded_targets fields."""
3737

3838
# Targets
39-
targets = attrs["targets"]
39+
if "targets" in attrs:
40+
targets = attrs["targets"]
4041

41-
target_extractor = extract_targets.TargetExtractor(targets_string=targets, private_ips_allowed=True, sort_targets=True)
42-
targets_dict = target_extractor.targets_dict
42+
target_extractor = extract_targets.TargetExtractor(targets_string=targets, private_ips_allowed=True, sort_targets=True)
43+
targets_dict = target_extractor.targets_dict
4344

44-
if targets_dict["invalid_targets"]:
45-
invalid_targets = ",".join(targets_dict["invalid_targets"])
46-
raise serializers.ValidationError(f"Invalid targets provided: {invalid_targets}")
45+
if targets_dict["invalid_targets"]:
46+
invalid_targets = ",".join(targets_dict["invalid_targets"])
47+
raise serializers.ValidationError(f"Invalid targets provided: {invalid_targets}")
4748

4849
# Excluded targets
49-
excluded_targets = attrs["excluded_targets"]
50+
if "excluded_targets" in attrs:
51+
excluded_targets = attrs["excluded_targets"]
5052

51-
target_extractor = extract_targets.TargetExtractor(targets_string=excluded_targets, private_ips_allowed=True, sort_targets=True)
52-
targets_dict = target_extractor.targets_dict
53+
target_extractor = extract_targets.TargetExtractor(targets_string=excluded_targets, private_ips_allowed=True, sort_targets=True)
54+
targets_dict = target_extractor.targets_dict
5355

54-
if targets_dict["invalid_targets"]:
55-
invalid_targets = ",".join(targets_dict["invalid_targets"])
56-
raise serializers.ValidationError(f"Invalid excluded targets provided: {invalid_targets}")
56+
if targets_dict["invalid_targets"]:
57+
invalid_targets = ",".join(targets_dict["invalid_targets"])
58+
raise serializers.ValidationError(f"Invalid excluded targets provided: {invalid_targets}")
5759

5860
return attrs
5961

0 commit comments

Comments
 (0)