Disable browser history on Chrome iOS #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, automated testing with Chrome on iOS is impossible. But in my tests on my iPad under iOS 9, this works. |
|
LGTM. Ideally if this is a CriOS bug, we can take this out at some point once it's fixed there. It's not so broken that this is a dealbreaker, but this is an improvement over the status quo. |
timdorr
added a commit
that referenced
this pull request
Nov 19, 2015
Disable browser history on Chrome iOS
|
Shoot, one thing - could you add an entry to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remix-run/react-router#2565