Make UPDATE_LOCATION follow FSA

[SimenB]

Fix #206

Could use redux-actions to create the action creator, but that seems overkill

[timdorr]

Thanks! This is a good start. Can you add the TRANSISTION actions as well?

[SimenB]

Ah, didn't bother with it as I thought it was internal.

Use redux-actions, or still do it manually?

[timdorr]

Spellchecker fail: TRANSITION actions.

[timdorr]

Manually. I don't think we need to add another dependency.

[SimenB]

@timdorr Done.

[timdorr]

Awesome! Thank you!

[SimenB]

@timdorr I didn't realize 2.0 was out of beta.

This is a breaking change, isn't it?
No references to the names of the properties in the docs or sample I could find, but people have still probably used location

[timdorr]

Shouldn't really be. The API is the same. Action shapes are internal and subject to change within the same minor version.

[SimenB]

aight 😄

[jlongster]

Well, not sure they are really internal, since people can listen to the UPDATE_LOCATION action. This is the sort of thing I hate about semver though, I don't want to release a whole 3.0.0 version just for this, especially since it's a quick change right after 2.0.0.

I don't really know how often people listen to that action, probably not much. We should definitely document it in the changelog though.

[SimenB]

Want me to add a PR for the changelog?

Edit: it is in the changelog, never mind

[valscion]

Well, not sure they are really internal, since people can listen to the UPDATE_LOCATION action.

Yeah, we do that. Glad I checked on the changelog before upgrading from beta version as this would've broke our stuff 😅

I agree that semver sucks in these cases. But I also don't really care at all even if this library's version would change from 2.0 to 3.0 within 4 days. It only tips me off to read the changelog if the major version changes — if there's only one change, it shouldn't be a hassle to upgrade immediately 😄

I'm just glad I didn't get burned before reading this issue ¯_(ツ)_/¯