(Do not merge!) Discussion: A userland replacement for replaceReducer #625
Conversation
| // Note: this is meant to be provided in a separate package. | ||
| // I'm only including it here for discussion. | ||
|
|
||
| const SWITCH_REDUCER = { type: 'redux-switch/SWITCH_REDUCER' }; |
There was a problem hiding this comment.
Any reason you've left off the @@ at the beginning?
There was a problem hiding this comment.
Leaving the @@ may be because this is intended to be implemented in userland.
There was a problem hiding this comment.
I interpreted "userland" to mean another npm package, a la redux-thunk et al.
There was a problem hiding this comment.
Ah, forgot about it. Yeah, it's probably better to leave it in because I can't imagine a siutation where you'd want to handle it.
|
Are there any drawbacks to this approach that come to mind? I really like this! |
|
@quicksnap Only downside I can think of is there's slightly more set-up for the developer |
|
Let's take it slow. |
Building on #624, here is a proposed replacement for
replaceReducerAPI that can be implemented in userland. Note how we no longer require<Root>component. Refs #350.