Skip to content

Commit f6326fe

Browse files
authored
fix: remove un-needed prysm vc check (ethereum#542)
1 parent a1ae708 commit f6326fe

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

src/vc/prysm.star

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,11 @@ def get_config(
3636
prysm_password_relative_filepath,
3737
)
3838

39-
if cl_context.client_name != constants.CL_TYPE.prysm:
40-
beacon_grpc_url = beacon_http_url[7:] # remove the "http://" prefix
41-
4239
cmd = [
4340
"--accept-terms-of-use=true", # it's mandatory in order to run the node
4441
"--chain-config-file="
4542
+ constants.GENESIS_CONFIG_MOUNT_PATH_ON_CONTAINER
4643
+ "/config.yaml",
47-
"--beacon-rpc-provider=" + cl_context.beacon_grpc_url,
48-
"--beacon-rest-api-provider=" + cl_context.beacon_grpc_url,
4944
"--wallet-dir=" + validator_keys_dirpath,
5045
"--wallet-password-file=" + validator_secrets_dirpath,
5146
"--suggested-fee-recipient=" + constants.VALIDATING_REWARDS_ACCOUNT,
@@ -70,7 +65,12 @@ def get_config(
7065
]
7166

7267
if cl_context.client_name != constants.CL_TYPE.prysm:
68+
cmd.append("--beacon-rpc-provider=" + beacon_http_url)
69+
cmd.append("--beacon-rest-api-provider=" + beacon_http_url)
7370
cmd.append("--enable-beacon-rest-api")
71+
else: # we are using Prysm CL
72+
cmd.append("--beacon-rpc-provider=" + cl_context.beacon_grpc_url)
73+
cmd.append("--beacon-rest-api-provider=" + cl_context.beacon_grpc_url)
7474

7575
if len(extra_params) > 0:
7676
# this is a repeated<proto type>, we convert it into Starlark

src/vc/vc_launcher.star

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -161,13 +161,6 @@ def launch(
161161
keymanager_enabled=keymanager_enabled,
162162
)
163163
elif vc_type == constants.VC_TYPE.prysm:
164-
# Prysm VC only works with Prysm beacon node right now
165-
if cl_context.client_name != constants.CL_TYPE.prysm:
166-
fail(
167-
cl_context.client_name
168-
+ "Prysm VC is only compatible with Prysm beacon node"
169-
)
170-
171164
config = prysm.get_config(
172165
el_cl_genesis_data=launcher.el_cl_genesis_data,
173166
image=image,

0 commit comments

Comments
 (0)