-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Gradle 5.2 #102
Comments
Hi @radarsh, gradle-test-logger-plugin/src/main/groovy/com/adarshr/gradle/testlogger/TestLoggerPlugin.groovy Lines 32 to 39 in c6f6b62
Reason is that currently the call to whenTaskAdded results in all tasks of Gradle to be realized, which is discouraged by the Gradle team. (see also https://docs.gradle.org/current/userguide/task_configuration_avoidance.html) |
This is going to be trickier than I thought as I am utilising |
@radarsh: Oh ... weird ... it worked for me when applying your plugin by overriding the plugin class implementation to make it work for now with Gradle 5. |
I've got a branch if you want to try it. The acid test is to run |
@radarsh: Worked just fine for me after switching to
By the way: You could update to Gradle 5.1.1 too (I didn't do this for the test, just FYI). |
Indeed it works. It was my bad as I was replacing just the line with |
would love to have this addressed, as the plugin can't be configured as-is in gradle 5.x (although default config runs) |
Upgrade to Gradle 5.2
The text was updated successfully, but these errors were encountered: