interactive projectile-grep like counsel-projectile-grep

[aspiers]

After reading #112 and #233, I have stopped using counsel-projectile and now have most projectile commands working nicely with selectrum. However I notice that projectile-grep does not dynamically update a list of candidates as more characters are entered, in the same way that counsel-projectile-grep did. Is there any way to achieve this?

[clemera]

This is discussed more generally in #114. You can achieve that currently with Selectrum by passing a dynamic candidate function to selectrum-read (we have examples of that in the wiki) but it's not clear if something like this could work nicely with default completion and dynamic completion tables. I think a good compromise would be to ask for the search term first and then give you a list back which you can use continuous completion on. I think @minad is also looking for approaches to implement such a command in consult.

[aspiers]

Thanks! I had missed #114 - I'll keep an eye on it and also check out the wiki!

[minad]

Can be closed? We have consult-grep, consult-ripgrep and consult-git-grep with project support now.

[aspiers]

Oh cool! I'll check them out.

[aspiers]

I've had a look at these 3 functions and they are almost perfect, but they are lacking the final piece in terms of integration with projectile-grep. Compare with counsel-projectile-grep, whose docstring says:

If inside a git project and ‘projectile-use-git-grep’ is non-nil, use git grep. Otherwise use grep recursively.

Although that doesn't explicitly say it, the key difference is that if you are visiting a file in a subdirectory of the git repo and you invoke counsel-projectile-grep, it will search the whole repo, not just the current subdirectory like the three consult grep functions mentioned above.

So ideally there would be an analogous consult-projectile-grep which when invoked from within a git repo, first changes directory to the repo root directory then uses consult-git-grep or consult-ripgrep to do the searching, and when invoked from outside a git directory, uses either consult-grep or consult-ripgrep as normal.

[minad]

@aspiers No, actually they are perfect ;)

I wrote above: with project support - they can be configured such that they behave like you described. But I must admit, the readme didn't mention project support before. I updated the readme. Please take a look.

[aspiers]

OK great, thanks. I had noticed the mention of project support and as a result even read the source for the three functions but had missed that the support is "hidden" in consult--directory-prompt. I now have it working. In the process I noticed a couple of minor issues but I'll file them on the consult repo to avoid spamming selectrum further. Thanks a lot!