-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing packages directly (not using Git) #149
Comments
My plan:
The main problem with this approach is that I'm not sure how to get the revision SHA when you're cloning master (i.e. initially). Any ideas? |
$ git ls-remote https://github.com/raxod502/straight.el refs/heads/master
4fb25b607b009ee2837e5fccfb19ffb51ef29eed refs/heads/master |
Amazing! Thanks. Requiring two network calls is of course not ideal but I think it would still be an improvement, especially when cloning repositories in parallel. |
This feature might not only be useful to reduce disk space usage. I just encountered a situation when Emacswiki package (dired+) in https://github.com/emacsmirror/ is quite outdated in comparison with the wiki version. This problem is likely unavoidable because packages in emacsmirror are updated manually. I would prefer if straight.el provided an option to download Emacswiki packages directly from Emacswiki to ensure the latest version. |
Sorry, but installing packages from Emacswiki will never be supported. See melpa/melpa#5008 for the reasoning. This issue is specifically for installing snapshots of packages that are hosted on GitHub and similar registries. |
To be frank, I thought that straight.el is possibly the safest way to install packages from such untrusted sources. Unlike direct download, I can easily view diff of the package when updating. Hence, I can directly review any suspicious changes in the package. |
What would The only way you get a diff is by installing from a Git-based repository. I don't think There's also https://github.com/emacsmirror/emacswiki.org; perhaps something can be extracted from there. But I don't think anything can be done on the |
What would `straight.el` be doing to produce such a diff, and how would it differ from a manual download? I don't see how `straight.el` downloading an untrusted file would be any more secure than you doing the same.
I imagine that straight.el can create local git repo on first download
and then automatically create an "update" commit when the package files
change. That commit will contain diff from the last downloaded version
of the package.
|
Hypothetically such a thing could be done, but it would be a totally novel feature---nothing remotely similar is currently supported in |
See #148 (comment) and #148 (comment).
The text was updated successfully, but these errors were encountered: