Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise 'add pin click' functionality to avoid overlay opening on map clicks #68

Closed
jokroese opened this issue Jul 3, 2024 · 3 comments · Fixed by #86
Closed

Revise 'add pin click' functionality to avoid overlay opening on map clicks #68

jokroese opened this issue Jul 3, 2024 · 3 comments · Fixed by #86
Assignees

Comments

@jokroese
Copy link
Member

jokroese commented Jul 3, 2024

I've found the new 'add pin click opens add overlay' functionality implemented in #62 pretty annoying. I now realise that previously I clicked off the map to close the moment popups. Now, each of these clicks opens the overlay. Showing the project to other people over the last few days, I've seen most people do this too, as well as clicking by accident when trying to scroll.

I suggest we get rid of this.

Instead, when we 'add pin click' on the map, it should lightly visually emphasise the add overlay button (e.g., growing slightly or a small shake) to show that with the add pin placed, the user is invited to click on the button to share the text of the moment.

@nielsbom
Copy link
Collaborator

nielsbom commented Jul 3, 2024

Totes agree.

@jokroese
Copy link
Member Author

jokroese commented Jul 4, 2024

Should we modify it to put this light emphasis on the button or remove it altogether? @queeringthemap, maybe you have opinions?

@queeringthemap
Copy link
Collaborator

Let's just remove it all together! It seemed to work fine before even without emphasis on the button. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants