feat: add statistics for multiclassification + refactoring and improvements #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivamarco
requested review from
maocorte,
dtria91 and
lorenzodagostinoradicalbit
rivamarco
commented
Jun 26, 2024
spark/Dockerfile
Outdated
There was a problem hiding this comment.
We will use pyproject and poetry lock from spark project instead of manually putting dependencies as it was before
rivamarco
commented
Jun 26, 2024
spark/README.md
Outdated
There was a problem hiding this comment.
How to use the local spark image
rivamarco
commented
Jun 26, 2024
spark/jobs/metrics/statistics.py
Outdated
There was a problem hiding this comment.
This will be squashed probably in only one method in future refactoring
rivamarco
commented
Jun 26, 2024
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.11" | ||
| python = "^3.10" |
There was a problem hiding this comment.
Spark image will use python 3.10 inside
rivamarco
commented
Jun 26, 2024
|
|
||
| complete_record = {"UUID": str(uuid.uuid4()), "REFERENCE_UUID": reference_uuid} | ||
|
|
||
| match model.model_type: |
There was a problem hiding this comment.
match case to handle different types of models
maocorte
approved these changes
Jun 26, 2024
dtria91
approved these changes
Jun 26, 2024
No vulnerabilities detectedNo vulnerabilities with HIGH,CRITICAL severity have been detected in the code. |
lorenzodagostinoradicalbit
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
pyproject.tomlfile to install dependencies