Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Don't require the configuration file #18

Open
radiovisual opened this issue Jun 6, 2024 · 1 comment
Open

Feature Request: Don't require the configuration file #18

radiovisual opened this issue Jun 6, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@radiovisual
Copy link
Owner

Ideally all of the configurable options from the JSON configuration can be passed in directly to the CLI. If all of the required options are passed in then the settings in the JSON file are not necessary. This means we:

  • can either "mix and match" where the CLI options can take priority over the same setting in the configuration (allowing both to be used together)
  • we can pass in a --no-config option and all required configurations would need to passed in via the command line, throwing relevant errors if invalid or missing configuration is found
  • Documentation should be added to the README about the usage (in the form of a --help page output) with example commands
@radiovisual radiovisual added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 6, 2024
@radiovisual
Copy link
Owner Author

I can see this being a feature for the long term, where sane defaults can be enforced but I dont think its that important for us to try and get rid of the configuration file completely, but instead, passing in the configuration options via the command line should overwrite settings in the config file. I see this being a better short-term solution to bring some flexibility to keeli (especially in CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant